Remove deprecated "page.header.cta_url" setting #4821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this lying around while doing bde92b6. Thought I'd just remove it but hesitated for these reasons:
Context:
Already deprecated since 4.13.0 (September 2018).
Not many sites would be affected: I glanced through the search results and there's not many live sites using Gemfile with MM version specified as
"~> 4.something"
(i.e. audience of SemVer).Most repos are full forks so they're not affected, and those who use the remote theme method without specifying a version will be affected nevertheless (regardless of whether we bump the version number).
Given the considerations above, I'm inclined to push this forward. Though for the first time of doing this, I'd like to ask for your input, @mmistakes.