Remove overlay and revert X to hamburger icon when popup disappears #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `.hidden-links` popup disappears after you move the cursor out of it. However, the white overlay on the screen does not disappear, as well as the `x` nav button on the top-right, remains as is. Now when you click anywhere on the screen the popup appears again, and the `x` nav button turns back to a hamburger menu button. And when you click on the hamburger menu, the popup disappears. now it's happening the exact opposite. To remedy this, the pop up menu as well as the `x` nav button should also return back to normal once the popup disappears. This commit fixes this issue.
|
No changes? |
iBug
force-pushed
the
revert-1-remove-overlay-with-popup
branch
from
31e5be6
to
6864aee
Compare
minyoongi96
pushed a commit
to minyoongi96/minyoongi96.github.io
that referenced
this pull request
Aug 26, 2024
…mistakes#3958) the `.hidden-links` popup disappears after you move the cursor out of it. However, the white overlay on the screen does not disappear, as well as the `x` nav button on the top-right, remains as is. Now when you click anywhere on the screen the popup appears again, and the `x` nav button turns back to a hamburger menu button. And when you click on the hamburger menu, the popup disappears. now it's happening the exact opposite. To remedy this, the pop up menu as well as the `x` nav button should also return back to normal once the popup disappears. This commit fixes this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix.
Summary
The pop up menu above disappears after you move the cursor out of it. However, the white overlay on the screen does not disappear, as well as the x nav button on the top-right, remains as is.
Now when you click anywhere on the screen, the popup appears again, and the x nav button turns back to a hamburger menu button.
And when you click on the hamburger menu, the popup disappears.
The functionality is now behaving in the exact opposite that we want to.
To remedy this, once the popup disappears the x nav button should also return back to normal (hamburger button)
This commit fixes this issue.
Context
This is a direct pull request. No related Github issue