Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add target attribute for navigation link #3056

Merged
merged 2 commits into from
May 5, 2024

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Jul 11, 2021

This PR adds target attribute for links in the navigation menu.

P.S. I think may be add attributes property for more flexible configuration these link?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@xjlin0
Copy link

xjlin0 commented Sep 11, 2021

in the meantime, I'd use [link name](https://www.example.com/){:target="_blank"}

@iBug
Copy link
Collaborator

iBug commented May 5, 2024

This one is sufficiently small for inclusion, but when the next attribute comes up (e.g. if someone asks for rel="whatever", I'll be eager to deprecate everything except url and title (which is in fact link text and thus essential) and move all of them to an attributes property.

@iBug iBug merged commit ceeda03 into mmistakes:master May 5, 2024
minyoongi96 pushed a commit to minyoongi96/minyoongi96.github.io that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants