Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remote theme instructions #2734

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

susanstevens
Copy link
Contributor

This is a documentation change.

Summary

Update remote theme installation instructions to indicate that jekyll-include-cache should be added to the Gemfile.

Context

I followed the remote theme installation instructions and got the following error when running bundle exec jekyll serve:

Dependency Error: Yikes! It looks like you don't have jekyll-include-cache or one of its dependencies installed. In order to use Jekyll as currently configured, you'll need to install this gem. The full error message from Ruby is: 'cannot load such file -- jekyll-include-cache' If you run into trouble, you can find helpful resources at https://jekyllrb.com/help/! 

Adding the jekyll-include-cache gem to my Gemfile resolved the error, so it should probably be part of the instructions.

* jekyll-install-cache gem should be added to Gemfile
@iBug
Copy link
Collaborator

iBug commented Nov 9, 2020

This may not be necessary as the next point says:

  1. Add jekyll-include-cache to the plugins array of your _config.yml.

@susanstevens
Copy link
Contributor Author

@iBug I thought calling out that you need to add jekyll-include-gem to the Gemfile would be helpful since step 2 only mentions adding it to _config.yml. I had to add it the Gemfile and add it to the plugins array in _config.yml.

@iBug
Copy link
Collaborator

iBug commented Nov 10, 2020

Shouldn't be like that... The gem is included with github-pages and adding it in _config.yml should suffice.

Additionally, appending group: :jekyll_plugins in Gemfile is equivalent to adding it in the config (with higher priority), so if the "canonical" way doesn't work for you, perhaps you should double-check your config for typos or such?

@akhyarrh
Copy link
Contributor

Shouldn't be like that... The gem is included with github-pages and adding it in _config.yml should suffice.

AFAIK, jekyll-include-cache is not included in github-pages gem: https://pages.github.com/versions/

jekyll-include-cache are added by theme: https://github.com/mmistakes/minimal-mistakes/blob/master/minimal-mistakes-jekyll.gemspec#L23

But maybe it will not loaded if theme is used via remote_theme, so that why Jekyll cant find jekyll-include-cache ?

@mmistakes
Copy link
Owner

mmistakes commented Nov 10, 2020

I believe @susanstevens and @akhyarrh are correct. jekyll-include-cache isn't a dependency of the GitHub Pages gem and needs to be included in the Gemfile to work.

The plugin is whitelisted to work on GitHub Pages, but it's not activated by default.

@mmistakes mmistakes merged commit 64dc575 into mmistakes:master Nov 14, 2020
friskgit pushed a commit to friskgit/minimal_website that referenced this pull request Aug 24, 2022
kaitokikuchi pushed a commit to kaitokikuchi/kaitokikuchi.github.io that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants