Regression for mmistakes#2332

[iBug]

This is a bug fix.

Summary

On the merged commit of #2332 (abf2943), there's already

minimal-mistakes/_includes/masthead.html

Line 12 in abf2943

<a class="site-logo" href="{{ '/' | relative_url }}"><img src="{{ logo_path | relative_url }}" alt=""></a>

Emphasis:

<img src="{{ logo_path | relative_url }}" alt="">
                       ^^^^^^^^^^^^^^

so the extra relative_url is the culprit for the duplicated base path for masthead logo when site.baseurl isn't resolved to /.

This PR resolves that bug by removing the extra relative_url. On a side note, I wouldn't blame the original PR suggester because the initial {% if site.logo contains "://" %} is rather misleading per se.

Context

#2332 Comment: #2332 (comment)

cc @Geekdude

[mmistakes]

Can you verify this works with externally hosted images? That is what the //: check is for. There are users who don't host the images on their site (not sure why you'd want to do that but they do...).

So we need to be able to do logo: http://cdn.whatever.com/my-external-logo.png and logo: /assets/images/my-logo.png

[iBug]

@mmistakes I've verified locally with both Jekyll 3.8.6 and Jekyll 4.0. Here are the results:

baseurl: /test
{{ "abcd" | relative_url }} -> /test/abcd
{{ "https://google.com/abcd" | relative_url }} -> https://google.com/abcd

So your worry isn't practical, Jekyll has already taken care of it with the relative_url filter.

[mmistakes]

OK cool. relative_url didn't use to work that way which is why that extra check was needed. Guess if they fixed that all the other spots in the theme where there's an absolute URL check could be removed. Think it's mostly in image includes... hero, galleries maybe, etc.

[iBug]

@mmistakes Running git blame over the Jekyll code base shows jekyll/jekyll@a66c478 (merge of jekyll/jekyll#6490) on November 5, 2017. The milestone suggests that the change was carried out with the release of Jekyll 3.7.0. So if you want to utilize this new feature, you might want to update this badge in README.md:

minimal-mistakes/README.md

Line 4 in 1799ddd

[](https://jekyllrb.com/)

I'd be happy to help if you want to perform the adoption of this change in Jekyll (3.6 → 3.7).