Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide posts with [hidden: true] from listings #2345

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

iBug
Copy link
Collaborator

@iBug iBug commented Dec 13, 2019

This is an enhancement or feature.

Hide posts which have hidden: true in their front matters from collection / category / tag listings, as is already done with home layout. This works for listing pages with layout: collection OR category OR tag.

@torrocus
Copy link
Contributor

torrocus commented Jan 3, 2020

Could you explain why exactly this functionality should be used?

Maybe you want to have posts you're still working on and don't want to publish yet?
This functionality is already in Jekyll. Use the _draft folder and the --draft option (https://jekyllrb.com/docs/posts/#drafts)

Also your way is fake-hiding. First of all, the post will still be public and can be accessed. Secondly, external gems do not know the "hidden" attribute and it will not work. RSS is a good example. There is still your "hidden post".

@iBug
Copy link
Collaborator Author

iBug commented Jan 3, 2020

@torrocus It's the default behavior for both jekyll-paginate and jekyll-paginate-v2, where posts with this attribute aren't listed in indices. Other than that this setting has no effect. But still, I'm relying on this to have pages that are "visible only if you know the link". Adding the functionality to other listings than the main index makes it more consistent.

@stale
Copy link

stale bot commented Feb 2, 2020

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Status: Stale label Feb 2, 2020
@iBug
Copy link
Collaborator Author

iBug commented Feb 2, 2020

not stale

@stale stale bot removed the Status: Stale label Feb 2, 2020
@stale
Copy link

stale bot commented Mar 3, 2020

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Status: Stale label Mar 3, 2020
@iBug
Copy link
Collaborator Author

iBug commented Mar 4, 2020

not stale again

@stale stale bot removed the Status: Stale label Mar 4, 2020
@mmistakes mmistakes merged commit 4bf72cf into mmistakes:master Mar 4, 2020
@iBug iBug deleted the hidden-posts branch March 5, 2020 04:09
jesuswasrasta pushed a commit to jesuswasrasta/jesuswasrasta.github.io that referenced this pull request Jul 8, 2020
mzaffran pushed a commit to mzaffran/mzaffran.github.io that referenced this pull request Jan 4, 2021
kaitokikuchi pushed a commit to kaitokikuchi/kaitokikuchi.github.io that referenced this pull request Sep 4, 2023
chukycheese pushed a commit to chukycheese/chukycheese.github.io that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants