Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube social links use legacy URL format #716

Closed
5 tasks done
iandoesallthethings opened this issue Dec 17, 2016 · 2 comments
Closed
5 tasks done

Youtube social links use legacy URL format #716

iandoesallthethings opened this issue Dec 17, 2016 · 2 comments

Comments

@iandoesallthethings
Copy link

iandoesallthethings commented Dec 17, 2016

  • This is a question about using the theme.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
  • This is a feature request. (kinda)
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.

Environment informations

  • Minimal Mistakes version: 4.1.0
  • github-pages or jekyll gem version: Jekyll gem version
  • Operating system: Windows 10 WSL (Ubuntu)

Expected behavior

Youtube social links (in sidebar and about) should be able to link to current url structure for channels:

http://www.youtube.com/channel/<CHANNEL_ID>
http://www.youtube.com/c/<CUSTOM_URL>

Currently, the author.youtube variable is being injected into the legacy format:

http://www.youtube.com/user/

This only works with older channels created before the structure changed.

Steps to reproduce the behavior

Add a channel ID or custom url to _config.yml.

After searching the repo, I found a couple of spots where the url is built from author.youtube, but I think that code is bundled in the gem, so I don't know how to edit it.

@mmistakes
Copy link
Owner

If you add the entire URL to your YouTube channel (eg. youtube: https://youtube.com/c/customURL) in _config.yml you should be all set.

Adding a username still works like it used. There's a check for :// now to determine which format to use.

@drhirsch
Copy link

Thank you! I had manually edited the code to do this; I really appreciate allowing the whole URL as a trigger for custom behavior!

jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017
martinbjeldbak added a commit to martinbjeldbak/martinbjeldbak.github.io that referenced this issue Feb 1, 2018
* upstream/master:
  New comment. (mmistakes#751)
  New comment. (mmistakes#750)
  Fix typo
  New comment. (mmistakes#745)
  New comment. (mmistakes#743)
  New comment. (mmistakes#729)
  Bump version to 4.1.1
  Update CHANGELOG.md and history
  Remove hardcoded read time values and make “minute read” values dynamic based off of `site.words_per_minute` - Close mmistakes#703
  Fix `author.youtube` conditional in author sidebar
  Change Jekyll to a runtime dependency
  Add support for YouTube channel URLs in `/docs` author sidebar
  Add support for YouTube channel URLs in author sidebar - Close mmistakes#716
  Update Font Awesome to v4.7.0 in `/docs`
  Update Font Awesome to v4.7.0 - Close mmistakes#723
  Bump version to 4.1.0
  Update CHANGELOG and history
  Add include for adding custom author profile links to sidebar
  Fix padding issue with pagination buttons - Close mmistakes#694
  Fix link to Discourse.org homepage in noscript section (mmistakes#699)
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this issue May 30, 2019
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this issue May 18, 2022
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this issue May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants