-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
12 changed files
with
19 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -126,7 +126,7 @@ To install: | |
bundle | ||
``` | ||
4. Add `remote_theme: "mmistakes/[email protected].1"` to your `_config.yml` file. Remove any other `theme:` or `remote_theme:` entry. | ||
4. Add `remote_theme: "mmistakes/[email protected].2"` to your `_config.yml` file. Remove any other `theme:` or `remote_theme:` entry. | ||
**Looking for an example?** Use the [Minimal Mistakes remote theme starter](https://github.com/mmistakes/mm-github-pages-starter/generate) for the quickest method of getting a GitHub Pages hosted site up and running. Generate a new repository from the starter, replace sample content with your own, and configure as needed. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,7 +74,7 @@ To install as a remote theme: | |
bundle | ||
``` | ||
4. Add `remote_theme: "mmistakes/[email protected].1"` to your `_config.yml` file. Remove any other `theme:` or `remote_theme:` entry. | ||
4. Add `remote_theme: "mmistakes/[email protected].2"` to your `_config.yml` file. Remove any other `theme:` or `remote_theme:` entry. | ||
You may also optionally specify a branch, [tag](https://github.com/mmistakes/minimal-mistakes/tags), or commit to use by appending an @ and the Git ref (e.g., `mmistakes/[email protected]` or `mmistakes/minimal-mistakes@bbf3cbc5fd64a3e1885f3f99eb90ba92af84063d`). This is useful when rolling back to older versions of the theme. If you don't specify a Git ref, the latest on `master` will be used. | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ To check which version you are currently using, view the source of your built si | |
|
||
``` | ||
<!-- | ||
Minimal Mistakes Jekyll Theme 4.20.1 by Michael Rose | ||
Minimal Mistakes Jekyll Theme 4.20.2 by Michael Rose | ||
Copyright 2013-2020 Michael Rose - mademistakes.com | @mmistakes | ||
Free for personal and commercial use under the MIT license | ||
https://github.com/mmistakes/minimal-mistakes/blob/master/LICENSE | ||
|
@@ -28,14 +28,14 @@ Simply run `bundle update` if you're using Bundler (have a `Gemfile`) or `gem up | |
When using Bundler you can downgrade or lock the theme to a specific release ([tag](https://github.com/mmistakes/minimal-mistakes/tags)), branch, or commit. Instead of `gem "minimal-mistakes-jekyll"` you'd add the following to your `Gemfile`: | ||
|
||
```ruby | ||
gem "minimal-mistakes-jekyll", :git => "https://github.com/mmistakes/minimal-mistakes.git", :tag => "4.20.1" | ||
gem "minimal-mistakes-jekyll", :git => "https://github.com/mmistakes/minimal-mistakes.git", :tag => "4.20.2" | ||
``` | ||
|
||
For more information on [installing gems from git repositories](http://bundler.io/v1.16/guides/git.html) consult Bundler's documentation. | ||
|
||
## Remote theme | ||
|
||
When setting `remote_theme: "mmistakes/[email protected].1"` in your `_config.yml` you may also optionally specify a branch, [tag](https://github.com/mmistakes/minimal-mistakes/tags), or commit to use by appending an @ and the Git ref. | ||
When setting `remote_theme: "mmistakes/[email protected].2"` in your `_config.yml` you may also optionally specify a branch, [tag](https://github.com/mmistakes/minimal-mistakes/tags), or commit to use by appending an @ and the Git ref. | ||
|
||
For example you can roll back to release 4.8.1 with `mmistakes/[email protected]` or a specific commit with `mmistakes/minimal-mistakes@bbf3cbc5fd64a3e1885f3f99eb90ba92af84063d`). For a complete list of theme versions consult the [releases page](https://github.com/mmistakes/minimal-mistakes/releases). | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
526445b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to have broken #2526
526445b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melat0nin You have a repo where this broke? Looks fine to me on the demo site.
https://mmistakes.github.io/minimal-mistakes/layout-post-date/
526445b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't unfortunately (it's private) but I got this error on Netlify, so had to lock MM to
4.20.1
:Liquid Exception: Could not locate the included file 'post__meta.html' in any of ["/opt/build/repo/_includes", "/opt/build/cache/bundle/ruby/2.6.0/gems/minimal-mistakes-jekyll-4.20.2/_includes"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your site source. in /opt/build/repo/_layouts/blog_post.html
I had updated the relevant layout (
blog_post.html
) previously, replacing{% include read-time.html %}
with{% include post__meta.html %}
526445b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's your issue. Those Jekyll includes changed names. Looks like you missed some files when you manually updated things.
If you have copies of
_includes
or_layouts
in your repo I would advise not doing that. Unless you're customizing something, but even then that makes upgrading harder as you need to track every change.Regardless, most of the changes were in this pull request. You'll have to compare it against your repo since it sounds like you're using it more like a fork than installing the theme.
#2641
526445b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay, yes I have done a fair bit of customisation -- I'll go back and compare my overrides and the theme more closely. Thanks!