-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Srcset not fetching all values for named transform #69
Comments
Thanks for reporting that. I just tagged Retcon 2.8.0 and 3.2.0 with a fix, for Craft 4 and Craft 5 respectively. |
Thank you for the quick turnaround. The named transforms are now functioning perfectly. |
@mmikkel Since this update we now get this issue We don't seem to be using the |
@bymayo That was a PHP 7 compatibility issue that was obvious as soon as I plugged in my brain 🙃 Just tagged Retcon 2.8.1 for Craft 3.x and 4.x with a fix. |
@mmikkel Amazing! Thanks! |
Hi, I am trying to generate image transforms using a named transform but it's not working as expected.
Steps to repoduce
Add a named transform to imager-x-transforms.php:
Try to use it in retconSrcset
Expected Output
<img src="../path/image.jpg" srcset="../path/image_W600.jpg 600w, ../path/image_W1200.jpg 1200w, ../path/image_W1800.jpg 1800w, ../path/image_W400.jpg 400w">
Actual Output
<img src="../path/image.jpg" srcset="../path/image_W600.jpg 600w, ./path/image_W400.jpg 400w">
Additional info
Retcon version: 2.7.5
Craft version: 4.9.7
PHP version: 8.0.2
The text was updated successfully, but these errors were encountered: