Fix MLX response masking and eval parity issues#2
Open
Lyxot wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several MLXTrainer/SFTTrainer parity issues around response masking, tokenization, and eval dataset handling.
MLX response-only batches kept fully masked samples
MLX only checked all-masked batches after batching, while the CUDA/SFT path filters samples whose post-mask labels are entirely
-100.Commit: 0fc7f14
Plain HF fast tokenizers failed in
train_on_responses_onlyMLX unwrapped any object with
_tokenizer, but HF fast tokenizers expose_tokenizeras the low-level Rust tokenizer, which is not callable likePreTrainedTokenizerBase.Commit: ae977ba
MLX text batching could double-add BOS
MLX used
tokenizer.encode(text)directly, while CUDA/SFT disables special-token insertion when rendered text already starts with BOS or the chat template owns BOS.Commit: 5dd5c00
Dict
eval_datasetwas treated as iterable rowsMLX passed dict eval datasets directly into batch creation/evaluation, so split names were iterated instead of preparing each eval split separately.
Commit: 4f70b5f