optimize the code in cmsFreeProfileSequenceDescription() #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, when I test the release version 2.15, I got the error below:
Based on simple analysis, it is because
pseq ->seq
is not checked in cmsFreeProfileSequenceDescription() of version 2.15.I found that the above problem is fixed in ac9e8e1, but the code could still be optimized:
if
pseq ->seq
is NULL, then it is unnecessary to enter the loop so that we just need to check the pointer one time.