Feat/ignite #1223
Merged
Feat/ignite #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dfalbel can you tag this with 'lantern' again please? |
dfalbel
added
the
lantern
|
@sebffischer Sorry for the delay! Just tagged ! |
sebffischer
commented
Jan 6, 2025
sebffischer
commented
Jan 6, 2025
| @@ -11,7 +11,7 @@ all: $(LANTERN_TARGET) $(SHLIB) rename | |||
| lantern: | |||
| @echo "*** Building lantern!" | |||
| mkdir -p ../build-lantern | |||
| cd ../build-lantern && cmake ../src/lantern -DCMAKE_INSTALL_PREFIX=$(PKG_PATH) -DCMAKE_INSTALL_MESSAGE="LAZY" @CMAKE_FLAGS@ && cmake --build . --target install --config Release | |||
| cd ../build-lantern && cmake ../src/lantern -DCMAKE_INSTALL_PREFIX=$(PKG_PATH) -DCMAKE_INSTALL_MESSAGE="LAZY" @CMAKE_FLAGS@ && cmake --build . --parallel 8 --target install --config Release | |||
There was a problem hiding this comment.
this still needs to be undone
sebffischer
commented
Jan 6, 2025
src/lantern/include/lantern/types.h
Outdated
| @@ -92,6 +92,10 @@ void* Argument (const std::vector<c10::Argument>& x); | |||
| void* FunctionSchema (const std::vector<c10::FunctionSchema>& x); | |||
| } // namespace vector | |||
|
|
|||
| // namespace optim { | |||
There was a problem hiding this comment.
needs to be removed
sebffischer
commented
Jan 6, 2025
src/lantern/include/lantern/types.h
Outdated
| @@ -481,6 +485,12 @@ void* FunctionSchema (const std::vector<c10::FunctionSchema>& x) { return make_p | |||
|
|
|||
| } // namespace vector | |||
|
|
|||
| // namespace optim { | |||
There was a problem hiding this comment.
needs to be removed
|
@dfalbel The tests are now basically passing, do you maybe have the time to look at this? |
|
This is a fantastic PR, @sebffischer! Thanks so much for the effort and hard work you put into it—it’s really appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1215
TODOs:
adamw_optionscustom struct, so maybe we also need to wrap it in avoid*