Skip to content

Re-add support for xmldiff on PHP 8.3 #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mlocati merged 3 commits into from
Oct 31, 2023
Merged

Re-add support for xmldiff on PHP 8.3 #821

mlocati merged 3 commits into from
Oct 31, 2023

Conversation

@ndossche
Copy link
Contributor

@ndossche ndossche commented Oct 30, 2023

Fixes #817.

@ndossche
Copy link
Contributor Author

ndossche commented Oct 30, 2023

Hmm, the error on buster is:

  /usr/local/include/php/ext/libxml/php_libxml.h:111:47: error: invalid conversion from 'void*' to 'php_libxml_doc_ptr*' [-fpermissive]
     php_libxml_invalidate_node_list_cache(docp->_private);

it looks like it has an outdated header as that code is not in the 8.3RC5 branch

@mlocati
Copy link
Owner

mlocati commented Oct 30, 2023

it looks like it has an outdated header as that code is not in the 8.3RC5 branch

Yep, it seems that they have dismissed support for PHP 8.3 on buster (see docker-library/php#1416)

@mlocati mlocati mentioned this pull request Oct 31, 2023
Merged
@mlocati mlocati merged commit 244407b into mlocati:master Oct 31, 2023
@mlocati
Copy link
Owner

mlocati commented Oct 31, 2023

Thanks!

abdomassoun pushed a commit to abdomassoun/docker-php-extension-installer that referenced this pull request Apr 3, 2025
@ndossche
Re-add support for xmldiff on PHP 8.3 (mlocati#821)
4b5e5a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-add support for xmldiff on PHP 8.3

2 participants

@ndossche @mlocati