Skip to content

include 4th response for SR,A,Auto in the check #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
araghun merged 2 commits into from
Feb 21, 2025
Merged

include 4th response for SR,A,Auto in the check #334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ce4abe
include 4th response for SR,A,Auto in the check
vimalnakum Feb 20, 2025
3785ea1
black changes
vimalnakum Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions compliance/check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,12 +262,13 @@ def get_command_by_value_and_number(cmd: str, number: int) -> Optional[str]:
initial_amps = get_initial_range(1, msgs[2]["reply"])
initial_volts = get_initial_range(3, msgs[2]["reply"])

initial_amps_command = get_command_by_value_and_number("SR,A", 3)
# sometimes the SR,A,Auto comes from 3rd or 4th response
initial_amps_command_3 = get_command_by_value_and_number("SR,A", 3)
initial_amps_command_4 = get_command_by_value_and_number("SR,A", 4)
initial_volts_command = get_command_by_value_and_number("SR,V", 3)

assert (
initial_amps_command == f"SR,A,{initial_amps}"
), f"Do not set Amps range as initial. Expected 'SR,A,{initial_amps}', got {initial_amps_command!r}."
assert (initial_amps_command_3 == f"SR,A,{initial_amps}") or (
initial_amps_command_4 == f"SR,A,{initial_amps}"
), f"Do not set Amps range as initial. Expected 'SR,A,{initial_amps}', got {initial_amps_command_3!r} and {initial_amps_command_4!r}."
assert (
initial_volts_command == f"SR,V,{initial_volts}"
), f"Do not set Volts range as initial. Expected 'SR,V,{initial_volts}', got {initial_volts_command!r}."
Expand Down