-
Notifications
You must be signed in to change notification settings - Fork 29
hopeful fix for dirty PSUs [ready for review and testing] #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
s-idgunji
merged 14 commits into
mlcommons:master
from
dmiskovic-NV:dejan-nv-dirty-psu-fix
Feb 3, 2023
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
26be2eb
hopeful fix for dirty PSUs
dmiskovic-NV 9be8b6e
hopeful fix for dirty PSUs
dmiskovic-NV 2cefad2
updated unit tests since one function changed
dmiskovic-NV dd522c1
fixed formatting
dmiskovic-NV 9dde8be
aaaand again
dmiskovic-NV 0622ef4
fixed some error
dmiskovic-NV 922fb0a
fixed watt averager
dmiskovic-NV 093fcea
fixed one oops
dmiskovic-NV 770355a
fixed one more oops
dmiskovic-NV 4d633d4
fixed one more oops
dmiskovic-NV 7cf79ce
back to fixing formatting
dmiskovic-NV 5aca317
what is the meaning of life?
dmiskovic-NV 0ca3593
no meaning
dmiskovic-NV 2980f54
cleaning up some leftovers
dmiskovic-NV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here power factor must also be multiplied right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly. and to get that, i need to modify max_volts_amps which will break all unit tests and when doing that, i'll just either base decision on power factor alone or rather on real power
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sure. I think using power factor alone should be reasonable here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'd need to make number up since power factor is not 100% reliable indicator of peak. THD is better, but PTD doesn't gather that. so instead i opted for modifying the function and also grabbing power