Add support for basic auth #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes: - An example Kaggle Croissant file that leverages the new auth - An update to the `README` to explain auth mechanism usage
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
Apologies for so many commits, but I couldn't get the tests to run locally, so had to rely on CI for testing. |
marcenacp
reviewed
Oct 18, 2023
| "url": "https://www.kaggle.com/datasets/unsdsn/world-happiness", | ||
| "distribution": [ | ||
| { | ||
| "contentUrl": "https://www.kaggle.com/api/v1/datasets/download/unsdsn/world-happiness", |
There was a problem hiding this comment.
Interesting. I thought a test would fail if the keys don't follow a pre-defined order. (This is to simplify the git changes when we migrate JSON-LD in bulk.)
marcenacp
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #233
This PR includes:
READMEto explain auth mechanism usage