Conversation
Ubospica
marked this pull request as ready for review
July 30, 2026 15:38
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动
XGrammar 是本仓库的语法约束生成库。缓存键是查找可复用编译结果时使用的标识。本改动直接使用已经规范化的 JSON 结构描述作为缓存键,避免再次解析、排序和序列化同一结构。
改动只影响结构化标签内部缓存,不改变公开接口。
性能与限制
固定 400 函数的阶段计时中,结构化标签转换从 96.199 毫秒降至 76.790 毫秒,减少 20.2%。后续完整数据集对照中,大型和小型结构化标签编译只减少 1.0% 和 3.0%;大型 JSON 结构描述增加 5.3%,但该入口不直接使用目标结构化标签缓存。
目标阶段曾有明确收益,但最新端到端数据没有证明广泛收益。评审重点是确认实际缓存命中场景是否足以采用这项改动。
正确性