Conversation
Signed-off-by: Artem Perevedentsev <aperevedents@nvidia.com>
arpera
requested review from
DarkSharpness,
Seven-Streams and
Ubospica
as code owners
July 24, 2026 14:15
…byte-path Signed-off-by: Artem Perevedentsev <aperevedents@nvidia.com>
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was found a bug when xgrammar accepts invalid json object
{"queries":["hello","]}. This json missed"close bracket for the second element in the array. The bug in xgrammar was inAcceptTokenthat did byte-by-byte processing for atomic tokens. This PR fixes this issue introducing a special set of all atomic tokens and forbids to process them byte-by-byte.Testing Done
This test fails on current xgrammar but passes with this PR.
N.B. The bug still persists in case of old API. If old API is deprecated now then consider highlighting that for users since now it is also possible to use old API and the bug persists for it.