Bump CMake minimum to v3.19 #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
afuller-TT
added a commit
to tenstorrent/tt-metal
that referenced
this pull request
Feb 7, 2025
### Ticket None ### Problem description Tokenizers CPP requires v3.19. See: mlc-ai/tokenizers-cpp#59 ### What's changed Rather than a conditional minimum hinged on whether we build TT-Train or not, just set the global minimum for the repo. ### Checklist - [ ] [All post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml) CI passes - [ ] [Blackhole Post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml) CI passes (if applicable) - [ ] [Model regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-models.yaml) CI passes (if applicable) - [ ] [Device performance regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml) CI passes (if applicable) - [ ] **(For models and ops writers)** Full [new models tests](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) CI passes (if applicable) - [ ] New/Existing tests provide coverage for changes
hschoi4448
pushed a commit
to tenstorrent/tt-metal
that referenced
this pull request
Feb 20, 2025
### Ticket None ### Problem description Tokenizers CPP requires v3.19. See: mlc-ai/tokenizers-cpp#59 ### What's changed Rather than a conditional minimum hinged on whether we build TT-Train or not, just set the global minimum for the repo. ### Checklist - [ ] [All post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/all-post-commit-workflows.yaml) CI passes - [ ] [Blackhole Post commit](https://github.com/tenstorrent/tt-metal/actions/workflows/blackhole-post-commit.yaml) CI passes (if applicable) - [ ] [Model regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-models.yaml) CI passes (if applicable) - [ ] [Device performance regression](https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml) CI passes (if applicable) - [ ] **(For models and ops writers)** Full [new models tests](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) CI passes (if applicable) - [ ] New/Existing tests provide coverage for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 144 is calling
add_library(tokenizers_c INTERFACE ${TOKENIZERS_RUST_LIB})The signature of add_library(... INTERFACE ...) that accepts sources was added in CMake v3.19 earlier versions error out if sources are provided to an interface library.
Bump the minimum version to reflect this. I also specified the upper policy level which helps with deprecation warnings in the future even if compatibility with old versions is maintained. Details of that can be found here: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html