Update CMakeLists.txt #2
Conversation
Add ${TOKENIZERS_C_LINK_LIBS} and append ${CMAKE_DL_LIBS} for Linux platform (mlc-ai#1 (comment))
|
|
||
| add_library(tokenizers_c INTERFACE ${TOKENIZERS_RUST_LIB}) | ||
| target_link_libraries(tokenizers_c INTERFACE ${TOKENIZERS_RUST_LIB}) | ||
| target_link_libraries(tokenizers_c INTERFACE ${TOKENIZERS_RUST_LIB} ${TOKENIZERS_C_LINK_LIBS}) |
There was a problem hiding this comment.
actually we can rename TOKENIZERS_CPP_LINK_LIBS to TOKENIZERS_C_LINK_LIBS as they are all intended to fix the rust lib deps
There was a problem hiding this comment.
Yeah, TOKENIZERS_CPP_LINK_LIBS can be replaced with TOKENIZERS_C_LINK_LIBS in this case. I think the TOKENIZERS_CPP_LINK_LIBS maybe also kept empty for extension of some other potential cpp extra libraries.
There was a problem hiding this comment.
What I meant is that we should move some of the TOKENIZERS_CPP_LINK_LIBS deps to TOKENIZERS_C_LINK_LIBS as they are related to C lib really
https://github.com/mlc-ai/tokenizers-cpp/blob/main/CMakeLists.txt#L20
and here
https://github.com/mlc-ai/tokenizers-cpp/blob/main/CMakeLists.txt#L37
|
Thanks @songkq , made some followup comments on moving some of the deps to |
move some of the TOKENIZERS_CPP_LINK_LIBS deps to TOKENIZERS_C_LINK_LIBS.
2 participants
Add ${TOKENIZERS_C_LINK_LIBS} and append ${CMAKE_DL_LIBS} for Linux platform (#1 (comment))