[Bugfix] Work around "Internal Compiler Error" in MSVC #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR found a workaround that prevents the nigthly windows pypi package of TVM Unity to be released. Basically it splits out a deeply nested method into several smaller ones so that MSVC's internal handling is supposed to be slightly simpler and less error prone.
yzh119
approved these changes
Jul 22, 2023
Member
yzh119
left a comment
yzh119
left a comment
There was a problem hiding this comment.
Thank you for the patch.
Some additional context: in windows CI/CD, the visual studio encounters internal compilation error on https://github.com/apache/tvm/blob/e4af30220f34a42cc3f0a9f4a564bb72c31de3c4/src/tir/transforms/compact_buffer_region.cc#L504.
junrushao
pushed a commit
to mlc-ai/package
that referenced
this pull request
Jul 22, 2023
Duplicate of #37 but pulled from `mlc-ai/decouple-win-mac` to enable self-hosted runners. The Windows build should have been fixed in mlc-ai/relax#271, kudos to @ junrushao. The Mac x86-64 is still buggy and is waiting for Cython 3 compatibility fix in TVM mainline. Let's merge this PR and make windows wheel work first.
MasterJH5574
pushed a commit
that referenced
this pull request
Jul 25, 2023
This PR found a workaround that prevents the nigthly windows pypi package of TVM Unity to be released. Basically it splits out a deeply nested method into several smaller ones so that MSVC's internal handling is supposed to be slightly simpler and less error prone.
tqchen
pushed a commit
that referenced
this pull request
Aug 1, 2023
[Bugfix] Work around "Internal Compiler Error" in MSVC (#271) This PR found a workaround that prevents the nigthly windows pypi package of TVM Unity to be released. Basically it splits out a deeply nested method into several smaller ones so that MSVC's internal handling is supposed to be slightly simpler and less error prone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR found a workaround that prevents the nigthly windows pypi package of TVM Unity to be released. Basically it splits out a deeply nested method into several smaller ones so that MSVC's internal handling is supposed to be slightly simpler and less error prone.