Coding challenge (Rafael Macapagal)

[rafael-gal]

Backend
Implemented PDF viewer API
Implemented Docs viewer API

Frontend
Created file reader

[Copilot]

Pull Request Overview

This PR implements a file viewer feature that allows users to view PDF and DOCX files. The backend provides new API endpoints for file content retrieval and viewing, while the frontend adds components to display these files appropriately.

• Added backend endpoints for viewing PDF files and converting DOCX files to HTML
• Enhanced frontend with file type detection and rendering components
• Updated file interface to include filename property

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
frontend/src/app/page.tsx	Added file viewer functionality with PDF and DOCX rendering components
backend/server.js	Implemented new API endpoints for file content retrieval and PDF viewing

Comments suppressed due to low confidence (4)

frontend/src/app/page.tsx:73

• Variable name 'file_split' uses snake_case which is inconsistent with the camelCase convention used throughout the codebase. Consider renaming to 'fileSplit'.

    const file_split = file.filename.split('.')

frontend/src/app/page.tsx:74

• Variable name 'file_type' uses snake_case which is inconsistent with the camelCase convention used throughout the codebase. Consider renaming to 'fileType'.

    const file_type = file_split.slice(-1)[0]

backend/server.js:59

• Variable name 'file_type' uses snake_case which is inconsistent with the camelCase convention used throughout the codebase. Consider renaming to 'fileType'.

  const file_type = path.extname(file.filename)

backend/server.js:80

• Variable name 'file_type' uses snake_case which is inconsistent with the camelCase convention used throughout the codebase. Consider renaming to 'fileType'.

  const file_type = path.extname(file.filename)

[Copilot]

Missing semicolon at the end of the filename property declaration. This is inconsistent with the other interface properties.

Suggested change

	filename: string
	filename: string;

[Copilot]

Using dangerouslySetInnerHTML with unsanitized HTML content from the server creates a potential XSS vulnerability. Consider sanitizing the HTML content before rendering.

[Copilot]

The iframe is missing important security attributes. Consider adding 'sandbox' and 'title' attributes for better security and accessibility.

Suggested change

	<iframe src={link} width={750} height={1000} />
	<iframe src={link} width={750} height={1000} sandbox="allow-scripts allow-same-origin" title="PDF Viewer" />

[Copilot]

Missing semicolon at the end of the statement. This is inconsistent with the coding style used elsewhere in the file.

Suggested change

	setFileLoading(true)
	setFileLoading(true);

[Copilot]

Missing semicolon at the end of the statement. This is inconsistent with the coding style used elsewhere in the file.

Suggested change

	console.error("file not found!")
	setFileLoading(false)
	return
	console.error("file not found!");
	setFileLoading(false);
	return;

[Copilot]

Inconsistent error response format. This endpoint uses 'message' property while other error responses use 'error' property. Should be consistent across the API.

Suggested change

	return res.status(422).json({ message: "Preview not supported" });
	return res.status(422).json({ error: "Preview not supported" });