LFM2.5 outputs [func(arg='value')] Pythonic syntax, not JSON#91
Merged
davidkoski merged 2 commits intoml-explore:mainfrom Feb 10, 2026
Merged
LFM2.5 outputs [func(arg='value')] Pythonic syntax, not JSON#91davidkoski merged 2 commits intoml-explore:mainfrom
davidkoski merged 2 commits intoml-explore:mainfrom
Conversation
Contributor
Author
|
cc @davidkoski @awni Looks like this fix should be added to |
This was referenced Feb 1, 2026
Contributor
Author
|
Hey @davidkoski , any chance this will be merged? any feedback for me |
4 tasks
Collaborator
Yes, the change looks good at first glance. Just working through a temporary backlog so it is delayed :-) I am rerunning CI (we/github had some infrastructure issues that made it fail). I will give a closer look provide feedback when I get a chance, but it may be ready to go. |
davidkoski
approved these changes
Feb 10, 2026
viktike
pushed a commit
to viktike/mlx-swift-lm
that referenced
this pull request
Mar 7, 2026
…ore#91) * added prefix matching for flexible parsing * convert to pythonic tool converter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
I was trying hard to debug why LFM2.5 still didn't call the tools correctly. After studying this: https://github.com/Liquid4All/cookbook/tree/main/examples/flight-search-assistant
It turns out LFM2 uses Pythonic syntax, not JSON.
I was able to verify this to be fully working now.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes