Fix many compiler warnings #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkoski
reviewed
Dec 4, 2025
| } | ||
| } | ||
|
|
||
| if let quantization = baseConfig.quantization { |
Collaborator
There was a problem hiding this comment.
curious why this was removed -- it is needed for quantization
davidkoski
reviewed
Dec 4, 2025
davidkoski
reviewed
Dec 4, 2025
|
|
||
| import Foundation | ||
| import MLX | ||
| @preconcurrency import MLX |
Collaborator
There was a problem hiding this comment.
I think this signals an issue -- MLX should have all the right concurrency annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There were around 180 compiler warnings, which I've reduced to 106. The remaining ones are due to concurrency issues that are more difficult to fix. I think these should be addressed separately. The large number of concurrency warnings probably led to many other warnings being overlooked, which can cause code quality to suffer.
Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes