Add GLM5 - #867
Merged
Merged
Conversation
Contributor
Author
|
@angeloskath @awni can't test the model out would any of you try it? |
Contributor
|
@Goekdeniz-Guelmez I've sent you a PR with some required changes. |
Contributor
Author
|
Nice! Thanks! |
3 tasks
Merged
Contributor
|
I think there's another issue, see: 4173038 |
Member
|
Thanks @kernelpool I incorporated it. I also removed the glm_moe_dsa model as it seems to be an exact copy of dsv32 so we just map tot hat. |
…dditional architectures
awni
force-pushed
the
add-glm-moe-dsa
branch
from
February 12, 2026 16:53
3426242 to
f792f6a
Compare
Member
|
Output is reasonable for a while but then becomes gibberish: |
Member
|
It's working now. There was an issue with the rope params. |
awni
approved these changes
Feb 12, 2026
awni
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks both for the contribution!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.