Align batch logits processor token contract#1115
Merged
angeloskath merged 3 commits intoml-explore:mainfrom Apr 7, 2026
Merged
Align batch logits processor token contract#1115angeloskath merged 3 commits intoml-explore:mainfrom
angeloskath merged 3 commits intoml-explore:mainfrom
Conversation
Member
|
Thanks for catching that. That's a typo actually. They should be receiving |
angeloskath
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #1072, the data sent to the batched logits processors changed:
self.tokens[e]is now a pythonlist[int], not mx.array. This means that the logits processors receive python lists.I believe this is a bug for two reasons:
# Update the token context that will be used by the logits processors, but see how_token_contextis not being used within the logits processors block.This PR brings the data sent to the logits processors in line with the pre-refactor data.