Don't use private exception class (not in latest huggingface_hub) #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamza-nabil
reviewed
Sep 18, 2024
| @@ -14,7 +14,6 @@ | |||
| import mlx.core as mx | |||
| import mlx.nn as nn | |||
| from huggingface_hub import snapshot_download | |||
| from huggingface_hub.utils._errors import RepositoryNotFoundError | |||
There was a problem hiding this comment.
it is not private, you can import it using :
from huggingface_hub.errors import RepositoryNotFoundErrorThere was a problem hiding this comment.
Well either way it's not in the latest hugging_face hub so we shouldn't use it.
There was a problem hiding this comment.
No , it is . all exceptions are defined in huggingface_hub.errors in the latest huggingface_hub release.
The huggingface_hub.utils._errors module was deleted in this PR to avoid confusion.
There was a problem hiding this comment.
You're right.. I missed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #988