Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History keyboard traveling is inconsistent #14

Closed
mkrl opened this issue Oct 14, 2021 · 1 comment · Fixed by #17
Closed

History keyboard traveling is inconsistent #14

mkrl opened this issue Oct 14, 2021 · 1 comment · Fixed by #17
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest For all the Hacktoberfest participants! help wanted Extra attention is needed released

Comments

@mkrl
Copy link
Owner

mkrl commented Oct 14, 2021

Describe the bug

Sometimes you can slip into the "undefined" territory when searching the command history with a keyboard. Also, the "down" history navigation would be nice to have

Steps to reproduce

Steps to reproduce the behavior:

  1. Open up the terminal
  2. Without typing any commands, press "up"
  3. See "undefined" show up in the terminal

Also, when navigating with the "down" arrow:

  1. Open up the terminal
  2. Type several commands
  3. Travel up the history and then down. It only works after pressing the "down" several times and is not consistent.

Expected behavior

Navigating the history when the history is empty should not print anything in the terminal.
Navigating down should be instant and should seamlessly scroll the history down.

ttty version

1.0.0

Additional context

A good place to start is here:

export const searchHistory = (instance: Terminal, isDown?: boolean) => {

@mkrl mkrl added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest For all the Hacktoberfest participants! labels Oct 14, 2021
fumblehool added a commit to fumblehool/ttty that referenced this issue Oct 16, 2021
fumblehool added a commit to fumblehool/ttty that referenced this issue Oct 16, 2021
@mkrl mkrl closed this as completed in #17 Oct 16, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest For all the Hacktoberfest participants! help wanted Extra attention is needed released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant