update to julia v1.6 and DataFrames v1.0 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 21, 2021 22:38
…s, also name collision ("Product") between this package and package "Distributions". Also add project.toml, etc.
Project.toml
with dataframes at version 0.21 , 0.22 gives errors.
Manifest.toml
(machine generated)
src\Life\Life_Constructors.jl
a few changes to account for df[i,:] being a DataFrameRow
src\S2Life\S2Life_Constructors.jl
conversion to a Symbol, or error.
test\S2Life_Test.jl
test\S2Life.jl
immaterial cleaning up.
…nings. src\Life\Life_Constructors.jl src\Life\Life_Functions.jl src\S2Life\S2Life_Functions.jl test\S2Life_Test.jl test\runtests.jl
qui apparaissaient dans le premier item de la test suite println("Testing S2 Life") . Essentiellement des appels de fonctions de dataframe.jl
test\Life_Input.jl
remplacé df[:myvar] par df[!myvar]
src\Life\Life_Functions.jl
idem
egalement remplacement de = (assignation) par .=
src\Life\Life_Constructors.jl
idem
il reste un warning de collision de nom sur Distributions.Product , dans le test de SST. src\ECModel\ECModel_Functions.jl remplacer df[:myvar] par df[!,:myvar] src\S2NonLife\S2NonLife_Functions.jl remplacer df[:myvar] par df[!,:myvar] test\ECModel.jl idem test\ECModel_Input.jl idem test\S2NonLife.jl idem test\runtests.jl idem
some deprecation warnings Project.toml change DataFrames= 0.21 to DataFrames= 0.22
due to deprecated convert(Array,df.dfr) or convert(Array,df.dfcol). All `convert`s in src files done, some `convert`s remain in test files. src\Life\Life_Functions.jl replace convert(Array,..) by Vector(..) src\S2Life\S2Life_Functions.jl replace convert(Array,..) by Vector(..) test\S2Life_Test.jl replace convert(Array,..) by Vector(..)
reumle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic spring cleaning, Only light syntax changes were needed to update the package.
Sorry for language in french in some earlier commits.
PS first pull request ever, so feel free to comment on what should be done better!