fix: parse multiple parameters #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @Don-CA, thanks for finding this bug and applying the fix. I want to avoid IDE specific configuration files in the repo, can you remove the file and/or add it to gitignore? |
Whoops! I swear I was careful about not adding it and yet it snuck in there. Gone now. |
|
Added another fix to make sure we only match exact paths. Does that seem right to you? |
|
Looks good. Just need to appease the rubocop and I can merge :) |
|
@Don-CA can you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Parse paths with multiple parameters correctly
Context
The original regular expression was too greedy and matched everything up to the last
}.A path of
/messages/{id}/{second_id}would capture{id}/{second_id}as a single group. This would confuse theOperationRouterwhich would failparameter_match?