Update rubocop → 1.56.1 (unknown) #147

depfu · 2023-08-28T13:55:14Z

👉 This PR is queued up to get rebased by Depfu

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.50.2 → 1.56.1) · Repo · Changelog

Release Notes

1.56.1

Bug fixes

#12136: Fix a false negative for Layout/LeadingCommentSpace when using #+ or #- as they are not RDoc comments. (@koic)

#12113: Fix a false positive for Bundler/DuplicatedGroup when groups are duplicated but source, git, platforms, or path values are different. (@koic)

#12134: Fix a false positive for Style/MethodCallWithArgsParentheses when parentheses are used in one-line in pattern matching. (@koic)

#12111: Fix an error for Bundler/DuplicatedGroup group declaration has keyword option. (@koic)

#12109: Fix an error for Style/ArgumentsForwarding cop when forwarding kwargs/block arg and an additional arg. (@ydah)

#12117: Fix a false positive for Style/ArgumentsForwarding cop when not always forwarding block. (@owst)

#12115: Fix an error for Style/Lambda when using numbered parameter with a multiline -> call. (@koic)

#12124: Fix false positives for Style/RedundantParentheses when parentheses in super or yield call with multiline style argument. (@koic)

#12120: Fix false positives for Style/SymbolArray when %i array containing unescaped [, ], (, or ). (@koic)

#12133: Fix Style/RedundantSelfAssignmentBranch to handle heredocs. (@r7kamura)

#12105: Fix target ruby Gem::Requirement matcher and version parsing to support multiple version constraints. (@ItsEcholot)

1.56.0

New features

#12074: Add new Bundler/DuplicatedGroup cop. (@OwlKing)

#12078: Make LSP server support rubocop.formatAutocorrectsAll execute command. (@koic)

Bug fixes

#12106: Fix a false negative for Style/RedundantReturn when returning value with guard clause and return is used. (@koic)

#12095: Fix a false positive for Style/Alias when EncforcedStyle: prefer_alias and using alias with interpolated symbol argument. (@koic)

#12098: Fix a false positive for Style/ClassEqualityComparison when comparing interpolated string class name for equality. (@koic)

#12102: Fix an error for Style/LambdaCall when using nested lambda call x.().(). (@koic)

#12099: Fix an incorrect autocorrect for Style/Alias when EncforcedStyle: prefer_alias_method and using alias with interpolated symbol argument. (@koic)

#12085: Fix an error for Lint/SuppressedException when AllowNil: true is set and endless method definition is used. (@koic)

#12087: Fix false positives for Style/ArgumentsForwarding with additional args/kwargs in def/send nodes. (@owst)

#12071: Fix Style/SymbolArray false positives when using square brackets or interpolation in a symbol literal in a percent style array. (@jasondoc3)

#12061: Support regex in StringLiteralsInInterpolation. (@jonas054)

#12091: With --fail-level A ignore non-correctable offenses at :info severity. (@naveg)

Changes

#12094: Add base64 gem to runtime dependency to suppress Ruby 3.3's warning. (@koic)

1.55.1

Bug fixes

#12068: Fix a false positive for Style/ReturnNilInPredicateMethodDefinition when the last method argument in method definition is nil. (@koic)

#12082: Fix an error for Lint/UselessAssignment when a variable is assigned and unreferenced in for with multiple variables. (@koic)

#12079: Fix an error for Style/MixinGrouping when mixin method has no arguments. (@koic)

#11637: Correct Rubocop for private_class_method method documentation. (@bigzed)

#12070: Fix false positive in Style/ArgumentsForwarding when receiver forwards args/kwargs. (@owst)

1.55.0

New features

#11794: Add support to Style/ArgumentsForwarding for anonymous arg/kwarg forwarding in Ruby 3.2. (@owst)

#12044: Make LSP server support layoutMode option to run layout cops. (@koic)

#12056: Make LSP server support lintMode option to run lint cops. (@koic)

#12046: Make ReturnNilInPredicateMethodDefinition aware of nil at the end of predicate method definition. (@koic)

Bug fixes

#12055: Allow parentheses in single-line match patterns when using the omit_parentheses style of Style/MethodCallWithArgsParentheses. (@gsamokovarov)

#12050: Fix a false positive for Layout/RedundantLineBreak when inspecting the % form string %\n\n. (@koic)

#12063: Fix Style/CombinableLoops when one of the loops is empty. (@fatkodima)

#12059: Fix a false negative for Style/StringLiteralsInInterpolation for symbols with interpolation. (@fatkodima)

#11834: Fix false positive for when variable in inside conditional branch in nested node. (@alexeyschepin)

#11802: Improve handling of [] and () with percent symbol arrays. (@jasondoc3)

#12052: Fix "Subfolders can't include glob special characters". (@meric426, @loveo)

#12062: Fix LoadError when loading RuboCop from a symlinked location on Windows. (@p0deje)

Changes

#12064: Make Style/RedundantArgument aware of exit and exit!. (@koic)

#12015: Mark Style/HashConversion as unsafe autocorrection. (@koic)

1.54.2

Bug fixes

#12043: Fix a false negative for Layout/ExtraSpacing when some characters are vertically aligned. (@koic)

#12040: Fix a false positive for Layout/TrailingEmptyLines to prevent the following incorrect autocorrection when inspecting the % form string %\n\n. (@koic)

#1867: Fix an error when AllCops:Exclude is empty in .rubocop.yml. (@koic)

#12034: Fix invalid byte sequence in UTF-8 error when using an invalid encoding string. (@koic)

#12038: Output the "server restarting" message to stderr. (@knu)

1.54.1

Bug fixes

#12024: Fix a false positive for Lint/RedundantRegexpQuantifiers when interpolation is used in a regexp literal. (@koic)

#12020: This PR fixes an infinite loop error for Layout/SpaceAfterComma with Layout/SpaceBeforeSemicolon when autocorrection conflicts. (@koic)

#12014: Fix an error for Lint/UselessAssignment when part of a multiple assignment is enclosed in parentheses. (@koic)

#12011: Fix an error for Metrics/MethodLength when using a heredoc in a block without block arguments. (@koic)

#12010: Fix false negatives for Style/RedundantRegexpArgument when using safe navigation operator. (@koic)

1.54.0

New features

#12000: Support safe or unsafe autocorrect config for LSP. (@koic)

Bug fixes

#12005: Fix a false negative for Lint/Debugger when using debugger method inside lambda. (@koic)

#11986: Fix a false positive for Lint/MixedCaseRange when the number of characters at the start or end of range is other than 1. (@koic)

#11992: Fix an unexpected NoMethodError for built-in language server when an internal error occurs. (@koic)

#11994: Fix an error for Layout/LineEndStringConcatenationIndentation when inspecting the % from string %\n\n. (@koic)

#12007: Fix an error for Layout/SpaceAroundOperators when using unary operator with double colon. (@koic)

#11996: Fix an error for Style/IfWithSemicolon when without branch bodies. (@koic)

#12009: Fix an error for Style/YodaCondition when equality check method is used without the first argument. (@koic)

#11998: Fix an error when inspecting blank heredoc delimiter. (@koic)

#11989: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using unicode chars. (@koic)

#12001: Fix code length calculator for method calls with heredoc. (@fatkodima)

#12002: Fix Lint/Void cop for __ENCODING__ constant. (@fatkodima)

Changes

#11983: Add Ridgepole files to default Include list. (@ydah)

#11738: Enhances empty_line_between_defs to treat configured macros like defs. (@catwomey)

1.53.1

Bug fixes

#11974: Fix an error for Style/RedundantCurrentDirectoryInPath when using string interpolation in require_relative. (@koic)

#11981: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using double quote and single quote characters. (@koic)

#11836: Should not offense single-quoted symbol containing double quotes in Lint/SymbolConversion . (@KessaPassa)

1.53.0

New features

#11561: Add new Lint/MixedCaseRange cop. (@rwstauner)

#11565: Add new Lint/RedundantRegexpQuantifiers cop. (@jaynetics)

#11925: Add new Style/RedundantCurrentDirectoryInPath cop. (@koic)

#11595: Add new Style/RedundantRegexpArgument cop. (@koic)

#11967: Add new Style/ReturnNilInPredicateMethodDefinition cop. (@koic)

#11745: Add new Style/YAMLFileRead cop. (@koic)

#11926: Support built-in LSP server. (@koic)

Bug fixes

#11953: Fix a false negative for Lint/DuplicateHashKey when there is a duplicated constant key in the hash literal. (@koic)

#11945: Fix a false negative for Style/RedundantSelfAssignmentBranch when using method chaining or arguments in ternary branch. (@koic)

#11949: Fix a false positive for Layout/RedundantLineBreak when using a line broken string. (@koic)

#11931: Fix a false positive for Lint/RedundantRequireStatement when using PP.pp. (@koic)

#11946: Fix an error for Lint/NumberConversion when using multiple number conversion methods. (@koic)

#11972: Fix an error for Lint/Void when CheckForMethodsWithNoSideEffects: true and using a method definition. (@koic)

#11958: Fix error for Style/IdenticalConditionalBranches when using empty parentheses in the if branch. (@koic)

#11962: Fix an error for Style/RedundantStringEscape when an escaped double quote precedes interpolation in a symbol literal. (@koic)

#11947: Fix an error for Style/ConditionalAssignment with an assignment that uses if branch bodies, which include a block. (@koic)

#11959: Fix false negatives for Layout/EmptyLinesAroundExceptionHandlingKeywords when using Ruby 2.5's rescue inside block and Ruby 2.7's numbered block. (@koic)

#10902: Fix an error for Style/RedundantRegexpEscape string with invalid byte sequence in UTF-8. (@ydah)

#11562: Fixed escaped octal handling and detection in Lint/DuplicateRegexpCharacterClassElement. (@rwstauner)

Changes

#11904: Mark Layout/ClassStructure as unsafe to autocorrect. (@nevans)

#8506: Add AllowedParentClasses config to Lint/MissingSuper. (@iMacTia)

1.52.1

Bug fixes

#11944: Fix an incorrect autocorrect for Style/SoleNestedConditional with Style/MethodCallWithArgsParentheses. (@koic)

#11930: Fix exception on Lint/InheritException when class definition has non-constant siblings. (@rafaelfranca)

#11919: Fix an error for Lint/UselessAssignment when a variable is assigned and unreferenced in for. (@koic)

#11928: Fix an incorrect autocorrect for Lint/AmbiguousBlockAssociation. (@koic)

#11915: Fix a false positive for Lint/RedundantSafeNavigation when &. is used for to_s, to_i, to_d, and other coercion methods. (@lucthev)

Changes

#11942: Require Parser 3.2.2.3 or higher. (@koic)

1.52.0

New features

#11873: Add ComparisonsThreshold config option to Style/MultipleComparison. (@fatkodima)

#11886: Add new Style/RedundantArrayConstructor cop. (@koic)

#11873: Add new Style/RedundantRegexpConstructor cop. (@koic)

#11841: Add new Style/RedundantFilterChain cop. (@fatkodima)

#11908: Support AllowedReceivers for Style/CollectionMethods. (@koic)

Bug fixes

#11890: Fix a false negative for Lint/RedundantSafeNavigation when &. is used for to_d. (@koic)

#11880: Fix a false positive for Style/ExactRegexpMatch when using literal with quantifier in regexp. (@koic)

#11902: Fix a false positive for Style/RequireOrder when single-quoted string and double-quoted string are mixed. (@koic)

#11879: Fix a false positive for Style/SelectByRegexp when Ruby 2.2 or lower analysis. (@koic)

#11891: Fix Style/AccessorGrouping to accept macros separated from accessors by space. (@fatkodima)

#11905: Fix an error for Lint/UselessAssignment when a variable is assigned with rest assignment and unreferenced. (@koic)

#11899: Fix an incorrect autocorrect for Style/SingleLineMethods when using Ruby 3.0 and Style/EndlessMethod is disabled. (@koic)

#11884: Make rubocop -V display rubocop-factory_bot version when using it. (@koic)

#11893: Fix a false positive for Lint/InheritException when inheriting Exception with omitted namespace. (@koic)

#11898: Fix offences in calls inside blocks with braces for Style/MethodCallWithArgsParentheses with omit_parentheses enforced style. (@gsamokovarov)

#11857: Server mode: only read $stdin when -s or --stdin argument provided. (@naveg)

1.51.0

New features

#11819: Add autocorrection for Lint/AmbiguousBlockAssociation. (@r7kamura)

#11597: Add autocorrection for Lint/UselessAssignment. (@r7kamura)

#11848: Add autocorrection for Lint/Void. (@r7kamura)

#11851: Add autocorrection for Naming/MemoizedInstanceVariableName. (@r7kamura)

#11856: Add autocorrection for Style/CombinableLoops. (@r7kamura)

#11824: Add autocorrection for Lint/TopLevelReturnWithArgument. (@r7kamura)

#11869: Add new Style/ExactRegexpMatch cop. (@koic)

#11814: Make Style/CollectionCompact aware of delete_if. (@koic)

#11866: Make Style/Semicolon aware of redundant semicolons in string interpolation braces. (@koic)

Bug fixes

#11812: Fix a false negative for Style/Attr when using attr and method definitions. (@koic)

#11861: Fix a false positive for Layout/SpaceAfterSemicolon when no space between a semicolon and a closing brace of string interpolation. (@koic)

#11830: Fix a false positive for Lint/IncompatibleIoSelectWithFiberScheduler. (@koic)

#11846: Fix a false positive for Lint/RedundantStringCoercion when using to_s(argument) in puts argument. (@koic)

#11865: Fix an error for Naming/ConstantName when assigning a constant from an empty branch of else. (@koic)

#11844: Fix a false positive for Style/RedundantLineContinuation when using line concatenation for assigning a return value and without argument parentheses. (@koic)

#11808: Fix a false positive for Style/RegexpLiteral when using a regexp starts with equal as a method argument. (@koic)

#11822: Fix an error for Layout/SpaceInsideBlockBraces when a method call with a multiline block is used as an argument. (@koic)

#11849: Fix an error for Style/ConditionalAssignment when EnforcedStyle: assign_inside_condition and using empty case condition. (@koic)

#11967: Fix error for Style/IfInsideElse when a deep nested multiline if...then...elsif...else...end. (@koic)

#11842: Fix an error for Style/IfUnlessModifier when using multiple if modifier in the long one line. (@koic)

#11835: Fix an error for Style/RequireOrder when multiple require are not sorted. (@koic)

#11809: Fix an incorrect autocorrect for Naming/RescuedExceptionsVariableName when exception variable is referenced after rescue statement. (@koic)

#11852: Fix an incorrect autocorrect for Style/EvalWithLocation when using eval without line number and with parenthesized method call. (@koic)

#11862: Fix an incorrect autocorrect for Style/GuardClause when using raise in else branch in a one-liner with then. (@koic)

#11868: Fix a false positive for Style/HashExcept when method's receiver/argument is not the same as block key argument. (@fatkodima)

#11858: Fix false positives when using source comments in blocks. (@reitermarkus)

#11510: Fix Lint/UselessAssignment false positive when using numbered block parameters. (@sambostock)

#11872: Fix Gemspec/DevelopmentDependencies not trigger when add_development_dependency has more then one arguments. (@Bhacaz)

#11820: Fix Lint/EmptyConditionalBody false-positives for commented empty elsif body. (@r7kamura)

Changes

#11859: Add rubocop-factory_bot to suggested extensions. (@ydah)

#10791: (Breaking) Drop runtime support for Ruby 2.6 and JRuby 9.3 (CRuby 2.6 compatible). (@koic)

#11826: Exclude **/*.jb from Lint/TopLevelReturnWithArgument. (@r7kamura)

#11871: Mark Style/DataInheritance as unsafe autocorrect, Style/OpenStructUse as unsafe, and Security/CompoundHash as unsafe. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

depfu · 2023-09-18T13:45:22Z

Closed in favor of #149.

depfu bot added the depfu label Aug 28, 2023

depfu bot mentioned this pull request Aug 28, 2023

Update rubocop → 1.55.1 (unknown) #145

Closed

Update rubocop to version 1.56.1

a2fc4f2

depfu bot force-pushed the depfu/update/rubocop-1.56.1 branch from 8b0381a to a2fc4f2 Compare September 15, 2023 19:41

depfu bot closed this Sep 18, 2023

depfu bot deleted the depfu/update/rubocop-1.56.1 branch September 18, 2023 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rubocop → 1.56.1 (unknown) #147

Update rubocop → 1.56.1 (unknown) #147

depfu bot commented Aug 28, 2023 •

edited

Loading

depfu bot commented Sep 18, 2023

Update rubocop → 1.56.1 (unknown) #147

Update rubocop → 1.56.1 (unknown) #147

Conversation

depfu bot commented Aug 28, 2023 • edited Loading

What changed?

✳️ rubocop (1.50.2 → 1.56.1) · Repo · Changelog

Bug fixes

New features

Bug fixes

Changes

Bug fixes

New features

Bug fixes

Changes

Bug fixes

Bug fixes

New features

Bug fixes

Changes

Bug fixes

New features

Bug fixes

Changes

Bug fixes

Changes

New features

Bug fixes

New features

Bug fixes

Changes

depfu bot commented Sep 18, 2023

depfu bot commented Aug 28, 2023 •

edited

Loading