Upgrade rubocop to version 1.29.0 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (1.28.2 → 1.29.0) · Repo · Changelog
Release Notes
1.29.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 28 commits:
Cut 1.29Update ChangelogSupport the cases that there is a method call in each branch[Fix #10325] Enhance `Style/RedundantCondition` by considering the case that variable assignments in each branchRemove an old reference to version 1.0Tweak uniformity of expression was implemented[Fix #10568] Add new `Style/EnvHome` copTweak highlight offense range for `InternalAffairs/MethodNameEndWith` copMerge pull request #10600 from nobuyo/add-new-internal-affairs-method-name-end-with-copAdd new `InternalAffairs/MethodNameEndWith` copEnhance the autocorrect of `Style/FetchEnvVar` (#10585)Merge pull request #10594 from nobuyo/fix-infinite-loop-on-style-multiline-ternary-operator[Fix #10592] Fix infinite loop on `Style/MultilineTernaryOperator` if using assignment method and condition/branch is multiline[Fix #10536] Fix validation for command-line options combination of `--display-only-fail-level-offenses` and `--auto-correct`[Fix #10586] Fix a false positive for `Style/DoubleNegation`Merge pull request #10582 from koic/fix_a_false_positive_for_style_fetch_env_var_copTweak runtime dependency for REXML[Fix #10570] Add new `Gemspec/DependencyVersion` copMerge pull request #10590 from nobuyo/fix-autocorrect-for-style-raise-args-with-compact-style[Fix #10589] Fix autocorrect for `Style/RaiseArgs` with `EnforcedStyle: compact` and exception object is assigned to a local variable.Update links that make use of deprecated git.io[Fix #10581] Fix a false positive for `Style/FetchEnvVar`[Fix #10579] Fix a false positive for `Style/FetchEnvVar`Add markdown formatter (#10542)[Fix #10539] Add AllowedPatterns to Naming/VariableNumber, VariableName (#10571)Retire `Lint/UselessElseWithoutRescue` copDrop Ruby 2.5 supportSwitch back the docs versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands