Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: @properties and categorize them as attributes #15

Conversation

pedrolabonia
Copy link

@pedrolabonia pedrolabonia commented Apr 16, 2022

Fixes #14, Fixes #9

We classify if functions are a @property by checking if they have property in labels.

Fixes:

  • @property now shows correctly alongside the attributes
  • @property renders correctly with CSS class doc-attribute
  • @property doesn't show parens anymore
  • All objects are not properly categorized (see issue#14)

For material theme only for now

@pedrolabonia
Copy link
Author

pedrolabonia commented Apr 16, 2022

@pawamoy
Copy link
Member

pawamoy commented Apr 16, 2022

Please keep separated changes in different PRs 🙂
One for #9 first. #14 needs something different (see my comment there). And the properties re-categorization should happen in a third PR, but I'd like that we discuss it a bit more, as it could be something we do in Griffe directly (see comment in #9).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show_category_heading: true and group_by_category: true does not work Properties are rendered with parens
2 participants