Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: The setter and deleter attribute should be set on the Attribute class, since that's how properties are instantiated #311

Closed
pawamoy opened this issue Aug 10, 2024 · 0 comments
Closed

bug: The setter and deleter attribute should be set on the Attribute class, since that's how properties are instantiated #311

pawamoy opened this issue Aug 10, 2024 · 0 comments
Assignees
@pawamoy
Labels
bug Something isn't working

Comments

@pawamoy
Copy link
Member

pawamoy commented Aug 10, 2024

Description of the bug

Properties are now instantiated as attributes, not functions. Therefore, the setter and deleter attributes should be set on the Attribute class, not the Function one.

To Reproduce

/

Full traceback

/

Expected behavior

/

Additional context

/
@pawamoy pawamoy added the bug Something isn't working label Aug 10, 2024
@pawamoy pawamoy self-assigned this Aug 10, 2024
pawamoy added a commit that referenced this issue Aug 11, 2024
@pawamoy
fix: Move setter and deleter to Attribute class instead of `Fun…
309c6e3 
…ction`, since that's how properties are instantiated

Issue-311: #311
@pawamoy pawamoy closed this as completed Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawamoy pawamoy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pawamoy