You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, griffe uses a regex over pth files that assumes each command is separated by a line break. I'm pretty unfamiliar with pth files, but ran into some issues with editable installs recently, which seem to trace back to pth files using ";" to terminate lines :/.
From the docs at https://docs.python.org/3/library/site.html: "Lines starting with import (followed by space or tab) are executed". Since the docs didn't mention semi-colons, we changed the previous split on ; to a split on \n in this commit: f212dd3. But I guess it's just ambiguous and semi-colons should be supported in executable lines.
Describe the bug
Currently, griffe uses a regex over pth files that assumes each command is separated by a line break. I'm pretty unfamiliar with pth files, but ran into some issues with editable installs recently, which seem to trace back to pth files using ";" to terminate lines :/.
Here is a pth file I noticed causing issues:
I noticed that...
griffe.finders._handle_pth_file
returned an empty list;
with a newline caused it to return the two entries pointing to the editable source directory.I don't know a lot about pth files, but wonder if this is a recent setuptools tweak or something? 😓
The text was updated successfully, but these errors were encountered: