-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of search index generation #60
Conversation
Did not give any decent search results without index on section level.
@@ -6,3 +6,4 @@ htmlcov/ | |||
mkdocs.egg-info/ | |||
*.pyc | |||
.coverage | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As other comment, let's keep these out, as they're really user-specific.
I've not fully reviewed, but looking great! |
Thanks for the feedback! I'm not very experienced in python and have a few "best-practices" to catch up on. Ill fix it right up. |
I'm having some trouble running the tests under windows. Have you tested that and do you have any feedback on how to set that up? Currently im running into issues with some tempfiles that does not/can not exist under windows. |
I've added a simple UI - see Hernrup#1 @Hernrup @tomchristie I'm developing this using a Docker container (ie, a boot2docker vm running on my windows box) would you be interested in my making a PR to add the Dockerfile and instructions to this project? |
we need to make sure that the title, and pagecontent in the generated json file does not contain any |
Ah! Good catch @SvenDowideit :) |
Turns out this solution is based on HTMLparser lib which will not work on python3. If someone has another lib that might work you are welcome to give it a shot. |
Closing in favour of #222 which builds on the changes in this PR. |
Solves #1
Note, only generation of search index (Tipue style). No theme views have been implemented.