Move get_block_root_node to FCR - #39
Merged
Merged
Conversation
brech1
reviewed
May 22, 2026
| version. | ||
|
|
||
| ```python | ||
| def get_block_root_node(block_root: Root) -> ForkChoiceNode: |
There was a problem hiding this comment.
This is great!
I would remove the note and rename to get_node_for_root. In this scenario, I would make sure this replaces inline constructions for default payloads in gloas
Owner
Author
There was a problem hiding this comment.
lmk, if this now looks good to you. I personally think it’s a better way of handling default payload status than how it is done in the original PR. Also, get_node_for_root is a much better name to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
get_block_root_nodedefinition from FC spec to the FCR spec.get_block_root_nodeis usedget_fork_choice_nodefunction is used which semantics is a superset ofget_block_root_nodesemanticscc @brech1