Handle Windows paths in git: URI construction #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative formulations that don't use gitApi.toGitUri are possible:
vscode.Uri.from({ …, path: "/" + path, … })
vscode.Uri.from({ …, path: vscode.Uri.file(path).path, … })
vscode.Uri.file(path).with({ scheme: …, query: … })
The first alternative works, but mixes forward- and back-slashes (the
incoming path has backslashes).
The last two alternatives should be equivalent and give the same result
as the version in this commit. All of them convert the directory
separators to forward slashes, so the final URI looks like (e.g.)
git:///c%3A/Users/me/Documents/…?…
Note: The path property in the encoded query component seems like it
must use backslashes on Windows. toGitUri uses fsPath for the encoded
path property. Also, I got a different failure opening the vscode.diff
link when I tried using slashes in the query's path property.
toGitUrl: https://github.com/microsoft/vscode/blob/65a6a2f783dbc87fb3b1408c6a9b3e8d455a60a2/extensions/git/src/uri.ts#L32
|
Amazing, thanks! I never noticed there was a toGitUri method. |
|
Just published 0.2.8 with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2 for me and seems like it should be platform independent.
Tested via "Launch Extension" and by
npx @vscode/vsce packageand loading the resulting.vsixfile.Tested using VS Code 1.91.1, Git 2.45.2.windows.1, Windows 10 22H2 build 19045.4651.