Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove ref to html-minifier/js-beautify/migrate #2666

Closed
wants to merge 6 commits into from

Conversation

iRyusa
Copy link
Member

@iRyusa iRyusa commented Apr 5, 2023

Not tested yet.

  • Need to write doc about how to keep the feature available for users.
  • Check how to handle this case in mjml-browser

@iRyusa iRyusa force-pushed the feature/optional-minifier-beautify branch from cd56ede to 70287dd Compare September 11, 2023 08:25
@phlogisticfugu
Copy link

@iRyusa - is this PR still the direction you want to go?

we want to use mjml, but currently cannot due to vulnerabilities in html-minifier and js-beautify

if you are open to PRs, could help with removing them

also, see in https://github.com/mjmlio/mjml/commits/v5.0.0-alpha.1/ that you more recently were thinking of replacing them.

@iRyusa
Copy link
Member Author

iRyusa commented Apr 25, 2024

Hi @phlogisticfugu ,
Minifier seem to be mandatory for MJML as it can prevent some bugs in some email clients, so yeah removing doesn't seem the best solution in our case.
For js-beautify, it's a different story as it make the "raw" output from MJML somewhat readable. I don't think this is a mandatory feature, but I think it's better to have a properly formatted output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants