Skip to content

Mjmlconfig #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2018
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/mjml/src/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
import path from 'path'
import fs from 'fs'

import mjml2html, { registerComponent } from 'mjml-core'
import { registerDependencies } from 'mjml-validator'

Expand Down Expand Up @@ -46,4 +49,19 @@ registerComponent(CarouselImage)

registerDependencies(require('./dependencies'))


try {
const mjmlConfig = fs.readFileSync(path.join(process.cwd(), '.mjmlconfig'));
const custom_comps = JSON.parse(mjmlConfig).packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelCase 👎

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups


custom_comps.forEach((compPath) => {
const requiredComp = require(path.join(process.cwd(), compPath))
registerComponent(requiredComp.default || requiredComp)
})
} catch(e) {
if (e.code !== 'ENOENT') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need a better error handling for each possible cases ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually ENOENT is the case where .mjmlconfig file does not exist
In this case we don't want to consider this as an error
For any other error we log it, but i haven't identified specific error cases

console.log('Error when registering custom components : ', e)
}
}

export default mjml2html