Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get autocompletion schema from preset. #391

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SebastianStehle
Copy link

At the moment, there is a hardcoded schema for autocompletion.

This PR removes that in favor of a schema that is created from the default preset.

Advantages:

  1. Always consistent with the implementation.
  2. It exposes the supported children, so it only recommends mj-carousel-image inside a mj-carousel.
  3. It exposes possible values for attributes, so you get additional autocompletion.

I had to change the sass implementation from node-sass to sass, because I was not able to get it running under windows. It has dependencies to very old python versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant