Skip to content

Commit

Permalink
[MLIR][OpenMP] Allow omp.atomic_update in SPMD loops (llvm#98)
Browse files Browse the repository at this point in the history
  • Loading branch information
skatrak authored Jun 27, 2024
1 parent 87ec30c commit fcd5871
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1543,6 +1543,15 @@ Operation *TargetOp::getInnermostCapturedOmpOp() {

bool TargetOp::isTargetSPMDLoop() {
Operation *capturedOp = getInnermostCapturedOmpOp();

// Allow an omp.atomic_update to be captured inside of the loop and still
// consider the parent omp.target operation to be potentially defining an SPMD
// loop.
// TODO: Potentially accept other captured OpenMP dialect operations as well,
// if they are allowed inside of an SPMD loop.
if (isa_and_present<AtomicUpdateOp>(capturedOp))
capturedOp = capturedOp->getParentOp();

if (!isa_and_present<LoopNestOp>(capturedOp))
return false;

Expand Down

0 comments on commit fcd5871

Please sign in to comment.