Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the ability to set your bell from the web app. #29

Merged
merged 9 commits into from
Jul 23, 2022
Merged

Added the ability to set your bell from the web app. #29

merged 9 commits into from
Jul 23, 2022

Conversation

sanderDijkxhoorn
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jul 15, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vanmoof-web-controller ✅ Ready (Inspect) Visit Preview Jul 21, 2022 at 7:39PM (UTC)

mjarkk
mjarkk requested changes Jul 16, 2022
View reviewed changes
components/Controls.tsx Outdated Show resolved Hide resolved
@sanderDijkxhoorn
Added new bell, label & styling
0f18e8e 
I will test everything when I am at my bike.
@sanderDijkxhoorn
Copy link
Contributor Author

Own I just found out I messed something up and with big text it looks like this:
image

@sanderDijkxhoorn
Copy link
Contributor Author

sanderDijkxhoorn commented Jul 16, 2022 •
edited
Loading

Should I just make the buttons like this?
image

Actually imma try to make everything smaller this looks too big

image

This looks better but I don't really like one button being larger then the other...

image

I think I will keep this, unless you know something better :)

@sanderDijkxhoorn sanderDijkxhoorn requested a review from mjarkk July 16, 2022 15:51
@sanderDijkxhoorn
Copy link
Contributor Author

It works but it's not responsive for mobile.

@sanderDijkxhoorn
Copy link
Contributor Author

sanderDijkxhoorn commented Jul 16, 2022 •
edited
Loading

It works but it's not responsive for mobile.

image

I will look into this asap :)

@mjarkk
Copy link
Owner

mjarkk commented Jul 18, 2022

Can we maybe shorten the names?
Like party horn can just be party

@sanderDijkxhoorn
Copy link
Contributor Author

So the only thing I would have to add is it to automatically read the current set bell? (if possible)

@mjarkk mjarkk merged commit 466b5ce into mjarkk:main Jul 23, 2022
@mjarkk
Copy link
Owner

mjarkk commented Jul 23, 2022

It would be great if we can can also show the current bell sound!

@sanderDijkxhoorn
Copy link
Contributor Author

It would be great if we can can also show the current bell sound!

Alright, I will try my best 😄

@sanderDijkxhoorn sanderDijkxhoorn mentioned this pull request Jul 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjarkk mjarkk Awaiting requested review from mjarkk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanderDijkxhoorn @mjarkk