Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Trajectory State to support Choreo moduleForces #725

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Eaglegrant
Copy link

As seen in Choreo's new TrajectoryState, moduleForces are pre-calculated.
This exposes those moduleForces, and updates the PathPlannerPath to make that possible.

@github-actions github-actions bot added the PathPlannerLib Changes to PathPlannerLib label Sep 22, 2024
@mjansen4857
Copy link
Owner

PathPlannerTrajectory is being updated to calculate and store its own module forces via #724. Support for Choreo's updates will need to be added to fit with that implementation. So, I'll leave this PR alone for now until that gets ironed out.

@mjansen4857
Copy link
Owner

After talking with the Choreo people a bit more it looks like Choreo's module forces are not going to be compatible with PPLib's motor torque feedforward stuff since those forces include the force due to friction. So, if anyone is going to use those fields, they will need to do so in a custom path following command. In that case, it makes more sense to just load the paths with ChoreoLib instead of PPLib so I don't think including these fields in PPLib makes a lot of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PathPlannerLib Changes to PathPlannerLib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants