feat: 🎸 sourcemap exclude vendors and auto turn on only for dev

mjancarik · Aug 26, 2024 · f0e8cd1 · f0e8cd1
1 parent dfeb3b0
commit f0e8cd1
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 2 deletions.
diff --git a/packages/cli/bin/merkur.mjs b/packages/cli/bin/merkur.mjs
@@ -15,6 +15,7 @@ program
   .name('merkur')
   .description('CLI for Merkur framework.')
   .option('--writeToDisk', 'Write built files to disk.')
+  .option('--sourcemap', 'Generate sourcemap.')
   .option('--runTask [runTask...]', 'Run only defined task.')
   .option('--outFile <string>', 'Server out file configuration in es-build.')
   .option('--port <number>', 'Widget server port.')

diff --git a/packages/cli/src/CLIConfig.mjs b/packages/cli/src/CLIConfig.mjs
@@ -10,6 +10,7 @@ export async function createCLIConfig({ args, command } = {}) {
     command: command ?? 'unknown',
     watch: args?.watch ?? !isProduction,
     writeToDisk: args?.writeToDisk ?? isProduction,
+    sourcemap: args?.sourcemap ?? !isProduction,
     outFile: args?.outFile ?? './build/widget.cjs',
     port: args?.port ?? 4444,
     runTask: args?.runTask ?? [],

diff --git a/packages/cli/src/buildConfig.mjs b/packages/cli/src/buildConfig.mjs
@@ -5,6 +5,7 @@ import manifestPlugin from 'esbuild-plugin-manifest';
 import { EMITTER_EVENTS, emitter, RESULT_KEY } from './emitter.mjs';
 import { memoryStaticPlugin } from './plugins/memoryStaticPlugin.mjs';
 import { metaPlugin } from './plugins/metaPlugin.mjs';
+import { excludeVendorsFromSourceMapPlugin } from './plugins/excludeVendorsFromSourceMapPlugin.mjs';
 
 export async function createBuildConfig({
   definition,
@@ -13,7 +14,7 @@ export async function createBuildConfig({
   cliConfig,
   context,
 }) {
-  const { isServer, writeToDisk } = config;
+  const { isServer, writeToDisk, sourcemap } = config;
   const { isProduction, outFile, staticFolder, projectFolder } = cliConfig;
 
   const entries = await getEntries({ merkurConfig, cliConfig });
@@ -23,7 +24,7 @@ export async function createBuildConfig({
       entryPoints: isServer ? entries.server : entries.client,
       bundle: true,
       treeShaking: isProduction,
-      sourcemap: true,
+      sourcemap,
       minify: isProduction,
       target: 'es2022',
       write: writeToDisk,
@@ -60,6 +61,7 @@ export async function createBuildConfig({
             },
           }),
         !writeToDisk && memoryStaticPlugin,
+        sourcemap && excludeVendorsFromSourceMapPlugin,
         metaPlugin,
         ...(definition.build?.plugins ?? []),
       ]

diff --git a/packages/cli/src/plugins/excludeVendorsFromSourceMapPlugin.mjs b/packages/cli/src/plugins/excludeVendorsFromSourceMapPlugin.mjs
@@ -0,0 +1,22 @@
+import fs from 'node:fs/promises';
+
+import { createLogger } from '../logger.mjs';
+
+export function excludeVendorsFromSourceMapPlugin({ cliConfig }) {
+  const logger = createLogger('excludeVendorsFromSourceMapPlugin', cliConfig);
+
+  return {
+    name: 'excludeVendorsFromSourceMapPlugin',
+    setup(build) {
+      build.onLoad({ filter: /node_modules/ }, async (args) => {
+        const contents = await fs.readFile(args.path, { encoding: 'utf8' });
+
+        return {
+          contents: contents 
+          + '\n//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbIiJdLCJtYXBwaW5ncyI6IkEifQ==',
+          loader: 'default',
+        }
+      })
+    },
+  };
+}
diff --git a/packages/cli/src/taskConfig.mjs b/packages/cli/src/taskConfig.mjs
@@ -9,6 +9,7 @@ export async function createTaskConfig({
     config: {
       isServer: definition?.build?.platform === 'node',
       writeToDisk: definition?.build?.write ?? cliConfig.writeToDisk,
+      sourcemap: definition?.build?.sourcemap ?? cliConfig.sourcemap,
       ...definition.config,
     },
     definition,