Various tweaks #775
Merged
Various tweaks #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oscfdezdz
commented
Feb 14, 2025
•
oscfdezdz
commented
| Before | After |
|---|---|
 |
 |
 |
 |
If not, it causes failures in some cases.
Shows more information when needed on smaller screens.
It also stops setting the orientation of the info bar to vertical in small window sizes, as there is too much empty horizontal space with the number of elements it has at the moment.
AdwComboRow, AdwButtonRow, AdwNavigationPage and AdwToastOverlay. Results page is not using AdwPreferencesPage's decription property as it has dimmed style by default and screen readers do not announce it.
oscfdezdz
force-pushed
the
various-tweaks
branch
from
ad5ab8d to
699a3b3
Compare
oscfdezdz
force-pushed
the
various-tweaks
branch
2 times, most recently
from
d1ebf2a to
1bd3f3f
Compare
Having getters to directly access widgets is a bad practice.
oscfdezdz
force-pushed
the
various-tweaks
branch
from
1bd3f3f to
e702b6b
Compare
oscfdezdz
force-pushed
the
various-tweaks
branch
from
60b1234 to
60ff010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.