Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish #465

Merged
merged 10 commits into from
Jan 31, 2025
Merged

Polish #465

merged 10 commits into from
Jan 31, 2025

Conversation

thgoebel
Copy link
Contributor

Lots of small UX and UI polishing. See the individual commits and their commit messages for details.

Copy link
Owner

@mjaakko mjaakko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

If you can, maybe also add translations for the texts you've added :)

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/java/xyz/malkki/neostumbler/MainActivity.kt Outdated Show resolved Hide resolved
app/build.gradle Outdated Show resolved Hide resolved
@mjaakko
Copy link
Owner

mjaakko commented Jan 31, 2025

Ah, sorry there was also another thing I forgot to mention. If you modify the settings, you also have to make the same modifications to the full variant. There is a little bit of duplication here, because the full variant includes a couple of additional settings and I haven't found a good way to share the code between the two variants

After that is done, I'm ready to merge this :)

@mjaakko mjaakko merged commit 2b84039 into mjaakko:master Jan 31, 2025
6 checks passed
@thgoebel thgoebel deleted the polish branch January 31, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants