Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Accuracy of Streaming Triangle Counting #242

Merged
merged 4 commits into from
Apr 28, 2024

Conversation

Ashok12011234
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 187 lines in your changes are missing coverage. Please review.

Project coverage is 1.29%. Comparing base (ea22010) to head (8fa0f7d).

Files Patch % Lines
.../query/algorithms/triangles/StreamingTriangles.cpp 0.00% 93 Missing ⚠️
src/frontend/JasmineGraphFrontEnd.cpp 0.00% 56 Missing ⚠️
...e/executor/impl/StreamingTriangleCountExecutor.cpp 0.00% 26 Missing ⚠️
src/frontend/core/domain/JobRequest.cpp 0.00% 4 Missing ⚠️
src/frontend/core/domain/JobResponse.cpp 0.00% 4 Missing ⚠️
src/server/JasmineGraphInstanceService.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #242   +/-   ##
======================================
  Coverage    1.29%   1.29%           
======================================
  Files          66      65    -1     
  Lines       13404   13399    -5     
  Branches     8834    8840    +6     
======================================
  Hits          173     173           
+ Misses      13030   13025    -5     
  Partials      201     201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@miyurud miyurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put few comments. Please address all of them.

Copy link
Owner

@miyurud miyurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put some more comments. Please address those.

Copy link

sonarcloud bot commented Apr 28, 2024

Quality Gate Passed Quality Gate passed

Issues
26 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

@miyurud miyurud merged commit 5c9298a into miyurud:master Apr 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants