Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
oxfmt を 0.38.0 から 0.37.0 に戻す。
背景
oxfmt 0.38.0 で
vite.config.*を設定ファイルとして自動検出する機能が追加された( oxc-project/oxc#20197 )。この機能はvite.config.tsのデフォルトエクスポートから.fmtフィールドを読み取ろうとするが、.fmtフィールドが存在しない場合にエラーになる不具合がある。この不具合により
apps/rendererのfixスクリプト(eslint . --fix -c eslint.config.fix.ts && oxfmt .)が失敗する。oxfmt 0.39.0 で
.fmtフィールドがないvite.config.tsをスキップするよう修正された( oxc-project/oxc#20254 )が、minimumReleaseAgeの制約で Renovate からの更新がまだ届いていないため、一時的に 0.37.0 に戻す。変更内容
パッケージ
確認事項
pnpm fix:allが成功することSummary by CodeRabbit