Skip to content

Revert oxlint to 1.52.0#77

Merged
miyaoka merged 1 commit intomainfrom
revert-oxlint-1.53.0
Mar 14, 2026
Merged

Revert oxlint to 1.52.0#77
miyaoka merged 1 commit intomainfrom
revert-oxlint-1.53.0

Conversation

@miyaoka
Copy link
Copy Markdown
Owner

@miyaoka miyaoka commented Mar 14, 2026

概要

oxlint を 1.53.0 から 1.52.0 に戻す。

背景

oxlint 1.53.0 で oxfmt 0.38.0 と同様に vite.config.ts を設定ファイルとして自動検出する機能が入った。vite.config.tslint フィールドがない場合にパースエラーになる。

Failed to parse oxlint configuration file.
Expected a `lint` field in the default export of vite.config.ts

PR #73 で oxfmt は 0.37.0 に戻したが、同じモノレポの oxlint 1.53.0 にも同じ問題があった。apps/renderer.ts ファイルに対して --type-aware で lefthook から実行した際に発覚。

確認事項

  • pre-commit hook で renderer の .ts ファイル変更時にエラーが出ないこと

Summary by CodeRabbit

  • Chores
    • Updated oxlint version in project configuration.

@miyaoka miyaoka self-assigned this Mar 14, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 14, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 463fb526-36cd-498a-ae81-e3ed6c32b42e

📥 Commits

Reviewing files that changed from the base of the PR and between ab32786 and b5b0101.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

The oxlint dependency in the pnpm workspace catalog was downgraded from version 1.53.0 to 1.52.0 in the pnpm-workspace.yaml configuration file.

Changes

Cohort / File(s) Summary
Dependency Version Update
pnpm-workspace.yaml
Downgraded oxlint from 1.53.0 to 1.52.0 in the workspace catalog.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A version hop, a number slide,
From fifty-three to fifty-two with pride,
Oxlint bends to our command,
Configuration in paw, we take a stand!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-oxlint-1.53.0
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@miyaoka miyaoka enabled auto-merge March 14, 2026 08:46
@miyaoka miyaoka merged commit 860ca3e into main Mar 14, 2026
4 of 5 checks passed
@miyaoka miyaoka deleted the revert-oxlint-1.53.0 branch March 14, 2026 08:46
@miyaoka miyaoka mentioned this pull request Mar 14, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant